Skip to content

Clarify instructions for 2FA verification#5895

Merged
janiceilene merged 3 commits intomainfrom
max/update-2fa
Apr 30, 2021
Merged

Clarify instructions for 2FA verification#5895
janiceilene merged 3 commits intomainfrom
max/update-2fa

Conversation

@max
Copy link
Copy Markdown
Contributor

@max max commented Apr 30, 2021

Why:

Clarify the instructions for 2FA verification with existing devices.

What's being changed:

Wording.

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (eg. a "before and after video")

The verification in this step of the process happens "with the device". The device is the thing that verifies not what is being verified.
@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 30, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 30, 2021
@max max marked this pull request as ready for review April 30, 2021 21:40
Copy link
Copy Markdown
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening a PR with this fix @max! I'll update the branch and get this merged in once tests are passing 🍏

@janiceilene janiceilene merged commit 0eb073e into main Apr 30, 2021
@janiceilene janiceilene deleted the max/update-2fa branch April 30, 2021 23:49
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants